Mercurial > public > ostc4

view Common/Inc/global_constants.h @ 319:d8e86af78474 fix-version

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
bugfix: correct packed main version number in dive header This fixes a rather mysterious bug. Users report that up to 1.3.5 beta, a correct version number is shown in libdivecomputer based applications (like in Subsurface, in the extra data tab). Careful examining the code in both libdivecomputer and the firmware shows a subtle error in the bit mask and shift operation to pack a full X.Y.Z.beta version number in 2 bytes (as is available in the dive header) in the firmware end (as the libdivecomputer code looks sane, assuming this is the right way to pack things). Likely, this bug crept in in the conversion from the closed source Keil period into the open source GCC setup of the code base. So its impossible to document the exact history of this problem here. Further notice that the main version number is only 1 of 3 version numbers, denoting the full version of the firmware (besides Font and RTE). Finally notice that this way of packing is limited to 2^5 bits (decimal 32), so we could easily build a 1.4.21, but not a 1.4.55. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Wed, 19 Jun 2019 14:31:50 +0200
parents a6c0375bc950
children 9660df857c57
line wrap: on
line source

///////////////////////////////////////////////////////////////////////////////
/// -*- coding: UTF-8 -*-
///
/// \file   Common/Inc/global_constants.h
/// \brief
/// \author Dmitry Romanov<kitt@bk.ru>
/// \date   11.2018
///
/// $Id$
///////////////////////////////////////////////////////////////////////////////
/// \par Copyright (c) 2014-2018 Heinrichs Weikamp gmbh
///
///     This program is free software: you can redistribute it and/or modify
///     it under the terms of the GNU General Public License as published by
///     the Free Software Foundation, either version 3 of the License, or
///     (at your option) any later version.
///
///     This program is distributed in the hope that it will be useful,
///     but WITHOUT ANY WARRANTY; without even the implied warranty of
///     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
///     GNU General Public License for more details.
///
///     You should have received a copy of the GNU General Public License
///     along with this program.  If not, see <http://www.gnu.org/licenses/>.
//////////////////////////////////////////////////////////////////////////////

#ifndef GLOBAL_CONSTANTS_H
#define GLOBAL_CONSTANTS_H
//Rename it ahead.
//Buttons section
#define DEFAULT_BUTTONRESPONSIVENESS_GUI 85
#define MIN_BUTTONRESPONSIVENESS_GUI 30 //50 (-10correction)
#define MAX_BUTTONRESPONSIVENESS_GUI 110//100 (+10correction)
#define MIN_BUTTONRESPONSIVENESS MIN_BUTTONRESPONSIVENESS_GUI-20 //MIN_BUTTONRESPONSIVENESS_GUI-20 correction
#define MAX_BUTTONRESPONSIVENESS MAX_BUTTONRESPONSIVENESS_GUI+20//MIN_BUTTONRESPONSIVENESS_GUI+20correction
#define BUTTON_DEBOUNCE_DELAY 50 //Delay for debounce filter for piezo buttons


// Spi sync data debug
#define SPI_SHOW_SYNC_STATS 0
#define SPI_MIN_ERROR_SHOW 10

/* Define INDEX for information exchanged within the header */
#define SPI_HEADER_INDEX_RX_STATE  (1)
#define SPI_HEADER_INDEX_TX_TICK   (2)

#define SPI_RX_STATE_OK 		(0)
#define SPI_RX_STATE_SHIFTED	(1)
#define SPI_RX_STATE_OFFLINE	(2)
#define SPI_RX_STATE_INVALID	(3)

//Text data
#define TEXT_PRESSURE_UNIT "hPa"
#endif