Mercurial > public > ostc4
annotate Common/Inc/global_constants.h @ 319:d8e86af78474 fix-version
bugfix: correct packed main version number in dive header
This fixes a rather mysterious bug. Users report that up to 1.3.5 beta,
a correct version number is shown in libdivecomputer based
applications (like in Subsurface, in the extra data tab). Careful
examining the code in both libdivecomputer and the firmware shows
a subtle error in the bit mask and shift operation to pack a full
X.Y.Z.beta version number in 2 bytes (as is available in the
dive header) in the firmware end (as the libdivecomputer code
looks sane, assuming this is the right way to pack things).
Likely, this bug crept in in the conversion from the closed
source Keil period into the open source GCC setup of
the code base. So its impossible to document the exact
history of this problem here.
Further notice that the main version number is only 1 of 3 version
numbers, denoting the full version of the firmware (besides Font
and RTE).
Finally notice that this way of packing is limited to 2^5 bits
(decimal 32), so we could easily build a 1.4.21, but not a
1.4.55.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Wed, 19 Jun 2019 14:31:50 +0200 |
| parents | a6c0375bc950 |
| children | 9660df857c57 |
| rev | line source |
|---|---|
| 101 | 1 /////////////////////////////////////////////////////////////////////////////// |
| 2 /// -*- coding: UTF-8 -*- | |
| 3 /// | |
| 4 /// \file Common/Inc/global_constants.h | |
| 5 /// \brief | |
| 6 /// \author Dmitry Romanov<kitt@bk.ru> | |
| 7 /// \date 11.2018 | |
| 8 /// | |
| 9 /// $Id$ | |
| 10 /////////////////////////////////////////////////////////////////////////////// | |
| 11 /// \par Copyright (c) 2014-2018 Heinrichs Weikamp gmbh | |
| 12 /// | |
| 13 /// This program is free software: you can redistribute it and/or modify | |
| 14 /// it under the terms of the GNU General Public License as published by | |
| 15 /// the Free Software Foundation, either version 3 of the License, or | |
| 16 /// (at your option) any later version. | |
| 17 /// | |
| 18 /// This program is distributed in the hope that it will be useful, | |
| 19 /// but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 20 /// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 21 /// GNU General Public License for more details. | |
| 22 /// | |
| 23 /// You should have received a copy of the GNU General Public License | |
| 24 /// along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| 25 ////////////////////////////////////////////////////////////////////////////// | |
| 26 | |
| 27 #ifndef GLOBAL_CONSTANTS_H | |
| 28 #define GLOBAL_CONSTANTS_H | |
| 29 //Rename it ahead. | |
| 30 //Buttons section | |
|
172
c659fda83e44
Minor: Button defaults, release date adjusted, use SPI_SHOW_SYNC_STATS
heinrichsweikamp
parents:
153
diff
changeset
|
31 #define DEFAULT_BUTTONRESPONSIVENESS_GUI 85 |
| 101 | 32 #define MIN_BUTTONRESPONSIVENESS_GUI 30 //50 (-10correction) |
| 33 #define MAX_BUTTONRESPONSIVENESS_GUI 110//100 (+10correction) | |
| 34 #define MIN_BUTTONRESPONSIVENESS MIN_BUTTONRESPONSIVENESS_GUI-20 //MIN_BUTTONRESPONSIVENESS_GUI-20 correction | |
| 35 #define MAX_BUTTONRESPONSIVENESS MAX_BUTTONRESPONSIVENESS_GUI+20//MIN_BUTTONRESPONSIVENESS_GUI+20correction | |
| 36 #define BUTTON_DEBOUNCE_DELAY 50 //Delay for debounce filter for piezo buttons | |
| 37 | |
| 38 | |
|
153
791cdfad0c8e
Added definitions for SPI sequence counter
Ideenmodellierer
parents:
104
diff
changeset
|
39 // Spi sync data debug |
|
172
c659fda83e44
Minor: Button defaults, release date adjusted, use SPI_SHOW_SYNC_STATS
heinrichsweikamp
parents:
153
diff
changeset
|
40 #define SPI_SHOW_SYNC_STATS 0 |
| 104 | 41 #define SPI_MIN_ERROR_SHOW 10 |
|
103
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
42 |
| 208 | 43 /* Define INDEX for information exchanged within the header */ |
| 44 #define SPI_HEADER_INDEX_RX_STATE (1) | |
|
263
a6c0375bc950
Forward 100ms time stamp to RTE and handle logbook in main loop
ideenmodellierer
parents:
208
diff
changeset
|
45 #define SPI_HEADER_INDEX_TX_TICK (2) |
|
153
791cdfad0c8e
Added definitions for SPI sequence counter
Ideenmodellierer
parents:
104
diff
changeset
|
46 |
| 208 | 47 #define SPI_RX_STATE_OK (0) |
| 48 #define SPI_RX_STATE_SHIFTED (1) | |
| 49 #define SPI_RX_STATE_OFFLINE (2) | |
| 50 #define SPI_RX_STATE_INVALID (3) | |
|
103
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
51 |
|
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
52 //Text data |
|
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
53 #define TEXT_PRESSURE_UNIT "hPa" |
| 101 | 54 #endif |
