Mercurial > public > ostc4
diff Discovery/Src/gfx_engine.c @ 296:87f83879cecb cleanup-3
Possible bugfix: do not use bitwise and (&)
This fixes a possible bug. A bitwise and (&) was used instead of the
intended boolean and (&&). I found this while code reading, and I'm not
aware of any user visible bug related to this, but it feels wrong
and possibly dangerous to use this construct here.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Thu, 16 May 2019 08:54:33 +0200 |
| parents | 0d97971b771b |
| children | 87d54b4fd946 |
line wrap: on
line diff
--- a/Discovery/Src/gfx_engine.c Mon May 13 13:37:34 2019 +0000 +++ b/Discovery/Src/gfx_engine.c Thu May 16 08:54:33 2019 +0200 @@ -1575,7 +1575,7 @@ dataMax++; dataDelta = (unsigned long)(dataMax - dataMin); dataDeltaHalve = dataDelta / 2; - while((w1 <= windowwidth) & (w2 < datalength)) + while((w1 <= windowwidth) && (w2 < datalength)) { int tmp = (10 * w1 * (long)datalength)/windowwidth; w2 = tmp/10;