Mercurial > public > ostc4

comparison Discovery/Src/gfx_engine.c @ 296:87f83879cecb cleanup-3

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Possible bugfix: do not use bitwise and (&) This fixes a possible bug. A bitwise and (&) was used instead of the intended boolean and (&&). I found this while code reading, and I'm not aware of any user visible bug related to this, but it feels wrong and possibly dangerous to use this construct here. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Thu, 16 May 2019 08:54:33 +0200
parents 0d97971b771b
children 87d54b4fd946
comparison
equal deleted inserted replaced
295:718e5feded62 296:87f83879cecb
1573 w2 = 0; 1573 w2 = 0;
1574 if(dataMax == dataMin) 1574 if(dataMax == dataMin)
1575 dataMax++; 1575 dataMax++;
1576 dataDelta = (unsigned long)(dataMax - dataMin); 1576 dataDelta = (unsigned long)(dataMax - dataMin);
1577 dataDeltaHalve = dataDelta / 2; 1577 dataDeltaHalve = dataDelta / 2;
1578 while((w1 <= windowwidth) & (w2 < datalength)) 1578 while((w1 <= windowwidth) && (w2 < datalength))
1579 { 1579 {
1580 int tmp = (10 * w1 * (long)datalength)/windowwidth; 1580 int tmp = (10 * w1 * (long)datalength)/windowwidth;
1581 w2 = tmp/10; 1581 w2 = tmp/10;
1582 int rest = tmp - w2*10; 1582 int rest = tmp - w2*10;
1583 if(rest >= 5) 1583 if(rest >= 5)