annotate Documentations/dump-disc.cfg @ 238:a9d798e8c11f div-fixes-5

cleanup, bugfix: do not mask I2C_SystemStatus with local variable This commit is partly cleanup, and partly possible bugfix. Masking the global I2C_SystemStatus with a local variable is (very) bad practice, but more importantly, dangerous, as other code uses this I2C_SystemStatus to base decisions on. So, this is definitely non-trivial, as it can possibly change the flow of control. This said, its tested and seems to have no negative effects (but also no positive, as I sort of hoped for), so that is why I mark it cleanup as well. Constructs like this shall be heavily documented in the code, when there is a reason to do things like this. Further, remove a 2nd rather useless construct. There is no reason to & 0x03 the output of I2C_SystemStatus. This is the only location in the entire code base where this is done, so, its not only useless but also inconsistent and confusing the true intentions here. Finally, littered to code with todo's that I will take care of in next commits. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Mon, 08 Apr 2019 10:16:17 +0200
parents 01cc5959f199
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
34
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
1 #! openocd -f
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
2 # Define the prob used:
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
3 source [find interface/stlink-v2.cfg]
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
4 set WORKAREASIZE 0x8000
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
5 transport select hla_swd
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
6
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
7 # Reset options
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
8 set ENABLE_LOW_POWER 1
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
9 set STOP_WATCHDOG 1
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
10 reset_config srst_only srst_nogate connect_assert_srst
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
11
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
12 # Seelct the right chip
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
13 set CHIPNAME stm32f427IIT6
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
14 set CONNECT_UNDER_RESET 1
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
15 source [find target/stm32f4x.cfg]
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
16
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
17 # Allow to continue execution after a connection:
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
18 init_reset run
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
19
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
20 puts "Flash banks:"
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
21 flash banks
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
22
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
23 #puts "Reading FIRMWARE..."
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
24 # Requires OpenOCD 0.10.0 / released January 2017 ?
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
25 #flash dump_image CPU1-DISC-dump.hex 0x00000000 0x8000
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
26
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
27 #puts "Done."
01cc5959f199 ... OpenOCD scripts to dump firmwares (not working)
jDG@sauge
parents:
diff changeset
28 exit