Mercurial > public > ostc4
changeset 471:73da921869d9 fix-bat-2
bugfix: implement battery charge percentage in dive header
This commit is (much) less trivial than the related 919e5cb51c92.
First, rename the CCRmode attribute (corresponding to byte Ox59) of
the SLogbookHeaderOSTC3. This byte (according to the hwOS interface
document) does not contain any CCR related value, but it contains
"battery information". Already since 2017, this byte is used from
libdivecomputer to interface the charge percentage. So, its
renamed from CCRmode to batteryCharge, to reflect its true purpose.
Now, simply add a batteryCharge attribute to the SLogbookHeader
(and see below why that is possible, without breaking things).
The remaining changes are trivial to implement battery charge
percentage in dive header.
Caveat: do not get confused by the exact role of the individual
logbook header types. SLogbookHeaderOSTC3 is the formal type of
the logbook format that the OSTC4 produces. This format is
supposed to identical to the format, as is used in hwOS for the
series of small OSTCs. Only some values of attributes are different.
For example, the OSTC4 supports VPM, so byte 0x79 (deco model used
for this dive) also has a value for VPM. But the SLogbookHeader
type, despite its name and structure, is *not* a true logbook
header, as it includes attributes that are not available in the
SLogbookHeaderOSTC3 formal header type.
Signed-off-by: Jan Mulder <jan@jlmulder.nl>
author | Jan Mulder <jlmulder@xs4all.nl> |
---|---|
date | Wed, 22 Apr 2020 13:08:57 +0200 |
parents | dd0d0952ef35 |
children | 8a375f0544d9 |
files | Discovery/Inc/logbook.h Discovery/Src/logbook.c |
diffstat | 2 files changed, 4 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/Discovery/Inc/logbook.h Wed Apr 15 07:01:11 2020 +0000 +++ b/Discovery/Inc/logbook.h Wed Apr 22 13:08:57 2020 +0200 @@ -75,6 +75,7 @@ uint8_t gfAtBeginning; uint8_t gfAtEnd; uint16_t personalDiveCount; + uint8_t batteryCharge; SSetpointLog setpoint[NUM_GAS]; uint16_t maxCNS; uint16_t averageDepth_mbar; @@ -125,7 +126,7 @@ uint8_t gfAtBeginning; uint8_t gfAtEnd; uint8_t personalDiveCount[2]; - uint8_t CCRmode; + uint8_t batteryCharge; uint8_t setpoint[5*2]; uint8_t salinity; uint8_t maxCNS[2];
--- a/Discovery/Src/logbook.c Wed Apr 15 07:01:11 2020 +0000 +++ b/Discovery/Src/logbook.c Wed Apr 22 13:08:57 2020 +0200 @@ -1287,6 +1287,7 @@ logbook_SetCompartmentDesaturation(pStateReal); logbook_SetLastStop(pStateReal->diveSettings.last_stop_depth_bar); gheader.batteryVoltage = pStateReal->lifeData.battery_voltage * 1000; + gheader.batteryCharge = pStateReal->lifeData.battery_charge; logbook_EndDive(); bDiveMode = 0; } else @@ -1604,7 +1605,7 @@ memcpy(headerOSTC3.diveNumber, &pHead->diveNumber, 2); headerOSTC3.diveMode = pHead->diveMode; - headerOSTC3.CCRmode = pHead->CCRmode; + headerOSTC3.batteryCharge = pHead->batteryCharge; memcpy(headerOSTC3.n2CompartDesatTime_min,pHead->n2CompartDesatTime_min, 16); memcpy(headerOSTC3.n2Compartments, pHead->n2Compartments, 64);