# HG changeset patch # User Jan Mulder # Date 1557989673 -7200 # Node ID 87f83879cecb4647d2c10d53eef94aaec96c3942 # Parent 718e5feded6254fb0dad14a0e8772d0243205b24 Possible bugfix: do not use bitwise and (&) This fixes a possible bug. A bitwise and (&) was used instead of the intended boolean and (&&). I found this while code reading, and I'm not aware of any user visible bug related to this, but it feels wrong and possibly dangerous to use this construct here. Signed-off-by: Jan Mulder diff -r 718e5feded62 -r 87f83879cecb Discovery/Src/gfx_engine.c --- a/Discovery/Src/gfx_engine.c Mon May 13 13:37:34 2019 +0000 +++ b/Discovery/Src/gfx_engine.c Thu May 16 08:54:33 2019 +0200 @@ -1575,7 +1575,7 @@ dataMax++; dataDelta = (unsigned long)(dataMax - dataMin); dataDeltaHalve = dataDelta / 2; - while((w1 <= windowwidth) & (w2 < datalength)) + while((w1 <= windowwidth) && (w2 < datalength)) { int tmp = (10 * w1 * (long)datalength)/windowwidth; w2 = tmp/10;