Mercurial > public > ostc4
view Small_CPU/Inc/vpm.h @ 319:d8e86af78474 fix-version
bugfix: correct packed main version number in dive header
This fixes a rather mysterious bug. Users report that up to 1.3.5 beta,
a correct version number is shown in libdivecomputer based
applications (like in Subsurface, in the extra data tab). Careful
examining the code in both libdivecomputer and the firmware shows
a subtle error in the bit mask and shift operation to pack a full
X.Y.Z.beta version number in 2 bytes (as is available in the
dive header) in the firmware end (as the libdivecomputer code
looks sane, assuming this is the right way to pack things).
Likely, this bug crept in in the conversion from the closed
source Keil period into the open source GCC setup of
the code base. So its impossible to document the exact
history of this problem here.
Further notice that the main version number is only 1 of 3 version
numbers, denoting the full version of the firmware (besides Font
and RTE).
Finally notice that this way of packing is limited to 2^5 bits
(decimal 32), so we could easily build a 1.4.21, but not a
1.4.55.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author | Jan Mulder <jlmulder@xs4all.nl> |
---|---|
date | Wed, 19 Jun 2019 14:31:50 +0200 |
parents | 5f11787b4f42 |
children |
line wrap: on
line source
/* * vpm.h * * Created: 23.04.2013 11:38:19 * Author: produktion04 */ #ifndef VPM_H #define VPM_H #include "data_central.h" extern long vpm_time_calc_begin; enum DECOLIST{DECOSTOPS,FUTURESTOPS,BAILOUTSTOPS,NULLZEIT,OFF = -1}; // order is important!! enum VPM_CALC_STATUS{CALC_END, CALC_BEGIN, CALC_CRITICAL, CALC_FINAL_DECO, CALC_NULLZEIT }; //int calc_crushing_pressure(float *starting_depth, float *ending_depth, float *rate); //void vpm_check_calc(unsigned short* stoplist); //void vpm_init(void); //_Bool vpm_crush(void); void vpm_reset_variables(void); _Bool vpm_build_variables_from_file(unsigned long in_sdram_start); int vpm_store_variables_in_sdram_for_transfer(unsigned long in_sdram_start); void vpm_calc_crushing_pressure(float starting_ambient_pressure, float ending_ambient_pressure, float rate); void vpm_deco_plan(unsigned short divetime,unsigned short * divetime_first_stop, float* first_stop_depth); float schreiner_equation__2(float *initial_inspired_gas_pressure,float *rate_change_insp_gas_pressure,float *interval_time_minutes, const float *gas_time_constant,float *initial_gas_pressure); int vpm_calc(SLifeData* pINPUT, SVpm* pVPM, SDecoinfo* pDECOINFO); void vpm_saturation_after_ascent(SLifeData* input); extern const float helium_time_constant[16]; extern const float nitrogen_time_constant[16]; #endif /* VPM_H */