Mercurial > public > ostc4
view Small_CPU/Inc/vpm.h @ 238:a9d798e8c11f div-fixes-5
cleanup, bugfix: do not mask I2C_SystemStatus with local variable
This commit is partly cleanup, and partly possible bugfix. Masking
the global I2C_SystemStatus with a local variable is (very) bad practice,
but more importantly, dangerous, as other code uses this I2C_SystemStatus
to base decisions on. So, this is definitely non-trivial, as it can
possibly change the flow of control. This said, its tested and seems to
have no negative effects (but also no positive, as I sort of hoped for),
so that is why I mark it cleanup as well. Constructs like this shall
be heavily documented in the code, when there is a reason to do things
like this.
Further, remove a 2nd rather useless construct. There is no reason
to & 0x03 the output of I2C_SystemStatus. This is the only location
in the entire code base where this is done, so, its not only useless
but also inconsistent and confusing the true intentions here.
Finally, littered to code with todo's that I will take care of in
next commits.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Mon, 08 Apr 2019 10:16:17 +0200 |
| parents | 5f11787b4f42 |
| children |
line wrap: on
line source
/* * vpm.h * * Created: 23.04.2013 11:38:19 * Author: produktion04 */ #ifndef VPM_H #define VPM_H #include "data_central.h" extern long vpm_time_calc_begin; enum DECOLIST{DECOSTOPS,FUTURESTOPS,BAILOUTSTOPS,NULLZEIT,OFF = -1}; // order is important!! enum VPM_CALC_STATUS{CALC_END, CALC_BEGIN, CALC_CRITICAL, CALC_FINAL_DECO, CALC_NULLZEIT }; //int calc_crushing_pressure(float *starting_depth, float *ending_depth, float *rate); //void vpm_check_calc(unsigned short* stoplist); //void vpm_init(void); //_Bool vpm_crush(void); void vpm_reset_variables(void); _Bool vpm_build_variables_from_file(unsigned long in_sdram_start); int vpm_store_variables_in_sdram_for_transfer(unsigned long in_sdram_start); void vpm_calc_crushing_pressure(float starting_ambient_pressure, float ending_ambient_pressure, float rate); void vpm_deco_plan(unsigned short divetime,unsigned short * divetime_first_stop, float* first_stop_depth); float schreiner_equation__2(float *initial_inspired_gas_pressure,float *rate_change_insp_gas_pressure,float *interval_time_minutes, const float *gas_time_constant,float *initial_gas_pressure); int vpm_calc(SLifeData* pINPUT, SVpm* pVPM, SDecoinfo* pDECOINFO); void vpm_saturation_after_ascent(SLifeData* input); extern const float helium_time_constant[16]; extern const float nitrogen_time_constant[16]; #endif /* VPM_H */