Mercurial > public > ostc4
view Small_CPU/Inc/compass_LSM303DLHC.h @ 238:a9d798e8c11f div-fixes-5
cleanup, bugfix: do not mask I2C_SystemStatus with local variable
This commit is partly cleanup, and partly possible bugfix. Masking
the global I2C_SystemStatus with a local variable is (very) bad practice,
but more importantly, dangerous, as other code uses this I2C_SystemStatus
to base decisions on. So, this is definitely non-trivial, as it can
possibly change the flow of control. This said, its tested and seems to
have no negative effects (but also no positive, as I sort of hoped for),
so that is why I mark it cleanup as well. Constructs like this shall
be heavily documented in the code, when there is a reason to do things
like this.
Further, remove a 2nd rather useless construct. There is no reason
to & 0x03 the output of I2C_SystemStatus. This is the only location
in the entire code base where this is done, so, its not only useless
but also inconsistent and confusing the true intentions here.
Finally, littered to code with todo's that I will take care of in
next commits.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Mon, 08 Apr 2019 10:16:17 +0200 |
| parents | 5f11787b4f42 |
| children |
line wrap: on
line source
/** ****************************************************************************** * @file compass_LSM303DLHC.h * @author heinrichs weikamp gmbh * @date 17-August-2017 * @version V0.1.0 * @since 17-August-2017 * @brief STMicroelectronics LSM303DLHC accelerometer & magnetometer driver * @verbatim ============================================================================== ##### How to use ##### ============================================================================== @endverbatim ****************************************************************************** * @attention * * <h2><center>© COPYRIGHT(c) 2017 heinrichs weikamp</center></h2> * ****************************************************************************** */ /* Define to prevent recursive inclusion -------------------------------------*/ #ifndef COMPASS_LSM303DLHC_H #define COMPASS_LSM303DLHC_H /* Exported constants --------------------------------------------------------*/ //#include "compass_LSM303D.h" #define DLHC_CTRL_REG1_A 0x20 #define DLHC_CTRL_REG2_A 0x21 #define DLHC_CTRL_REG3_A 0x22 #define DLHC_CTRL_REG4_A 0x23 #define DLHC_CTRL_REG5_A 0x24 #define DLHC_CTRL_REG6_A 0x25 #define DLHC_CRA_REG_M 0x00 #define DLHC_CRB_REG_M 0x01 #define DLHC_MR_REG_M 0x02 #define DLHC_OUT_X_L_M 0x03 #define DLHC_OUT_X_H_M 0x04 #define DLHC_OUT_Y_L_M 0x05 #define DLHC_OUT_Y_H_M 0x06 #define DLHC_OUT_Z_L_M 0x07 #define DLHC_OUT_Z_H_M 0x08 // identisch mit 303D #define DLHC_OUT_X_L_A 0x28 #define DLHC_OUT_X_H_A 0x29 #define DLHC_OUT_Y_L_A 0x2A #define DLHC_OUT_Y_H_A 0x2B #define DLHC_OUT_Z_L_A 0x2C #define DLHC_OUT_Z_H_A 0x2D #endif /* COMPASS_LSM303DLHC_H */ /******************* (C) COPYRIGHT 2017 heinrichs weikamp *****END OF FILE****/