Mercurial > public > ostc4
view Small_CPU/Inc/RTE_FlashAccess.h @ 238:a9d798e8c11f div-fixes-5
cleanup, bugfix: do not mask I2C_SystemStatus with local variable
This commit is partly cleanup, and partly possible bugfix. Masking
the global I2C_SystemStatus with a local variable is (very) bad practice,
but more importantly, dangerous, as other code uses this I2C_SystemStatus
to base decisions on. So, this is definitely non-trivial, as it can
possibly change the flow of control. This said, its tested and seems to
have no negative effects (but also no positive, as I sort of hoped for),
so that is why I mark it cleanup as well. Constructs like this shall
be heavily documented in the code, when there is a reason to do things
like this.
Further, remove a 2nd rather useless construct. There is no reason
to & 0x03 the output of I2C_SystemStatus. This is the only location
in the entire code base where this is done, so, its not only useless
but also inconsistent and confusing the true intentions here.
Finally, littered to code with todo's that I will take care of in
next commits.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Mon, 08 Apr 2019 10:16:17 +0200 |
| parents | 5f11787b4f42 |
| children | 91a8f9893e68 |
line wrap: on
line source
/** ****************************************************************************** * @file RTE_FLashAccess.h based on BonexFLashAccess.h based on firmwareEraseProgram.h * @author heinrichs weikamp gmbh * @version V0.0.1 * @date 20-July-2016 * @version V0.0.1 * @since 20-July-2016 * @brief erase and program the STM32F4xx internal FLASH memory for compasss calib etc. * @verbatim ============================================================================== ##### How to use ##### ============================================================================== @endverbatim ****************************************************************************** * @attention * * <h2><center>© COPYRIGHT(c) 2016 heinrichs weikamp</center></h2> * ****************************************************************************** */ /* Define to prevent recursive inclusion -------------------------------------*/ #ifndef RTE_FLASH_ACCESS_H #define RTE_FLASH_ACCESS_H #ifdef __cplusplus extern "C" { #endif /* Includes ------------------------------------------------------------------*/ #include "stm32f4xx_hal.h" /* Exported variables --------------------------------------------------------*/ /* Exported types ------------------------------------------------------------*/ enum { BFA_OK = 0, //= HAL_OK BFA_ERROR = (uint8_t)HAL_ERROR, BFA_BUSY = (uint8_t)HAL_BUSY, BFA_TIMEOUT = (uint8_t)HAL_TIMEOUT, BFA_EMPTY, }; /* Exported functions --------------------------------------------------------*/ uint8_t BFA_readLastDataBlock(uint32_t *dataArray4); uint8_t BFA_writeDataBlock(const uint32_t *dataArray4); #ifdef __cplusplus } #endif #endif /* RTE_FLASH_ACCESS_H */ /************************ (C) COPYRIGHT heinrichs weikamp *****END OF FILE****/