Mercurial > public > ostc4
view ostc4pack/README.linux @ 306:2f43419102c8 cleanup-4
bugfix, cleanup: do not clip depth to 0
A real dive with the previous commits shows that testing from the simulator
cannot be fully trusted in relation to logic that is close to the depth
sensor (that is obviously bypassed using the simulator). So 1) there is
3 second interval between the stopwatch and the divetime, and 2) the depth
flips from 1m depth to surface 0m depth, and that is visible in the
profile data.
Point 2) is definitely caused by the removed code in this commit. It likely
is not right to clip the depth value at all. It is fine to base decisions like is
done in is_ambient_pressure_close_to_surface on it, but clipping the depth value
itself is seems wrong. This has become more prominent with commit eba8d1eb5bef
where the clipping depth changed from 40cm of depth to 1m of depth. When
comparing profiles from an OSTC Plus, it shows that no depth clipping is
present there, so that is one more argument to remove it here.
Point 1) The 3 sec interval is likely not a coincidence. It is the time
to travel for 1m depth with a default descend speed of 20m/min.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author | Jan Mulder <jlmulder@xs4all.nl> |
---|---|
date | Wed, 22 May 2019 14:39:04 +0200 |
parents | 9c77cfe8c2b2 |
children |
line wrap: on
line source
README.linux ------------ 1. Compile the pack utilities cd src make checksum_final_add_fletcher make OSTC4pack_V4 2. Edit create_full_update_bin.sh Set BUILD_PATH to the location where you build the individual parts of the firmware using the OpenSTM23 IDE. Set BUILD_TYPE the either Debug or Release (or any other build style you defined in the OpenSTM23 IDE). Set the "build project names" as defined in the OpenSTM23 IDE. 3. Simpy run create_full_update_bin.sh Run it in the ostc4pack folder of the repository, and a file with name like OSTC4_<date>.bin is created containg the individual blobs.