Mercurial > public > ostc4
view Small_CPU/Inc/compass_LSM303DLHC.h @ 306:2f43419102c8 cleanup-4
bugfix, cleanup: do not clip depth to 0
A real dive with the previous commits shows that testing from the simulator
cannot be fully trusted in relation to logic that is close to the depth
sensor (that is obviously bypassed using the simulator). So 1) there is
3 second interval between the stopwatch and the divetime, and 2) the depth
flips from 1m depth to surface 0m depth, and that is visible in the
profile data.
Point 2) is definitely caused by the removed code in this commit. It likely
is not right to clip the depth value at all. It is fine to base decisions like is
done in is_ambient_pressure_close_to_surface on it, but clipping the depth value
itself is seems wrong. This has become more prominent with commit eba8d1eb5bef
where the clipping depth changed from 40cm of depth to 1m of depth. When
comparing profiles from an OSTC Plus, it shows that no depth clipping is
present there, so that is one more argument to remove it here.
Point 1) The 3 sec interval is likely not a coincidence. It is the time
to travel for 1m depth with a default descend speed of 20m/min.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Wed, 22 May 2019 14:39:04 +0200 |
| parents | 5f11787b4f42 |
| children |
line wrap: on
line source
/** ****************************************************************************** * @file compass_LSM303DLHC.h * @author heinrichs weikamp gmbh * @date 17-August-2017 * @version V0.1.0 * @since 17-August-2017 * @brief STMicroelectronics LSM303DLHC accelerometer & magnetometer driver * @verbatim ============================================================================== ##### How to use ##### ============================================================================== @endverbatim ****************************************************************************** * @attention * * <h2><center>© COPYRIGHT(c) 2017 heinrichs weikamp</center></h2> * ****************************************************************************** */ /* Define to prevent recursive inclusion -------------------------------------*/ #ifndef COMPASS_LSM303DLHC_H #define COMPASS_LSM303DLHC_H /* Exported constants --------------------------------------------------------*/ //#include "compass_LSM303D.h" #define DLHC_CTRL_REG1_A 0x20 #define DLHC_CTRL_REG2_A 0x21 #define DLHC_CTRL_REG3_A 0x22 #define DLHC_CTRL_REG4_A 0x23 #define DLHC_CTRL_REG5_A 0x24 #define DLHC_CTRL_REG6_A 0x25 #define DLHC_CRA_REG_M 0x00 #define DLHC_CRB_REG_M 0x01 #define DLHC_MR_REG_M 0x02 #define DLHC_OUT_X_L_M 0x03 #define DLHC_OUT_X_H_M 0x04 #define DLHC_OUT_Y_L_M 0x05 #define DLHC_OUT_Y_H_M 0x06 #define DLHC_OUT_Z_L_M 0x07 #define DLHC_OUT_Z_H_M 0x08 // identisch mit 303D #define DLHC_OUT_X_L_A 0x28 #define DLHC_OUT_X_H_A 0x29 #define DLHC_OUT_Y_L_A 0x2A #define DLHC_OUT_Y_H_A 0x2B #define DLHC_OUT_Z_L_A 0x2C #define DLHC_OUT_Z_H_A 0x2D #endif /* COMPASS_LSM303DLHC_H */ /******************* (C) COPYRIGHT 2017 heinrichs weikamp *****END OF FILE****/