Mercurial > public > ostc4
view Common/Inc/global_constants.h @ 306:2f43419102c8 cleanup-4
bugfix, cleanup: do not clip depth to 0
A real dive with the previous commits shows that testing from the simulator
cannot be fully trusted in relation to logic that is close to the depth
sensor (that is obviously bypassed using the simulator). So 1) there is
3 second interval between the stopwatch and the divetime, and 2) the depth
flips from 1m depth to surface 0m depth, and that is visible in the
profile data.
Point 2) is definitely caused by the removed code in this commit. It likely
is not right to clip the depth value at all. It is fine to base decisions like is
done in is_ambient_pressure_close_to_surface on it, but clipping the depth value
itself is seems wrong. This has become more prominent with commit eba8d1eb5bef
where the clipping depth changed from 40cm of depth to 1m of depth. When
comparing profiles from an OSTC Plus, it shows that no depth clipping is
present there, so that is one more argument to remove it here.
Point 1) The 3 sec interval is likely not a coincidence. It is the time
to travel for 1m depth with a default descend speed of 20m/min.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
| author | Jan Mulder <jlmulder@xs4all.nl> |
|---|---|
| date | Wed, 22 May 2019 14:39:04 +0200 |
| parents | a6c0375bc950 |
| children | 9660df857c57 |
line wrap: on
line source
/////////////////////////////////////////////////////////////////////////////// /// -*- coding: UTF-8 -*- /// /// \file Common/Inc/global_constants.h /// \brief /// \author Dmitry Romanov<kitt@bk.ru> /// \date 11.2018 /// /// $Id$ /////////////////////////////////////////////////////////////////////////////// /// \par Copyright (c) 2014-2018 Heinrichs Weikamp gmbh /// /// This program is free software: you can redistribute it and/or modify /// it under the terms of the GNU General Public License as published by /// the Free Software Foundation, either version 3 of the License, or /// (at your option) any later version. /// /// This program is distributed in the hope that it will be useful, /// but WITHOUT ANY WARRANTY; without even the implied warranty of /// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the /// GNU General Public License for more details. /// /// You should have received a copy of the GNU General Public License /// along with this program. If not, see <http://www.gnu.org/licenses/>. ////////////////////////////////////////////////////////////////////////////// #ifndef GLOBAL_CONSTANTS_H #define GLOBAL_CONSTANTS_H //Rename it ahead. //Buttons section #define DEFAULT_BUTTONRESPONSIVENESS_GUI 85 #define MIN_BUTTONRESPONSIVENESS_GUI 30 //50 (-10correction) #define MAX_BUTTONRESPONSIVENESS_GUI 110//100 (+10correction) #define MIN_BUTTONRESPONSIVENESS MIN_BUTTONRESPONSIVENESS_GUI-20 //MIN_BUTTONRESPONSIVENESS_GUI-20 correction #define MAX_BUTTONRESPONSIVENESS MAX_BUTTONRESPONSIVENESS_GUI+20//MIN_BUTTONRESPONSIVENESS_GUI+20correction #define BUTTON_DEBOUNCE_DELAY 50 //Delay for debounce filter for piezo buttons // Spi sync data debug #define SPI_SHOW_SYNC_STATS 0 #define SPI_MIN_ERROR_SHOW 10 /* Define INDEX for information exchanged within the header */ #define SPI_HEADER_INDEX_RX_STATE (1) #define SPI_HEADER_INDEX_TX_TICK (2) #define SPI_RX_STATE_OK (0) #define SPI_RX_STATE_SHIFTED (1) #define SPI_RX_STATE_OFFLINE (2) #define SPI_RX_STATE_INVALID (3) //Text data #define TEXT_PRESSURE_UNIT "hPa" #endif