diff Discovery/Src/logbook.c @ 283:04cdeff80254 ndl-in-logbook

Bugfix: write NDL in logbook correctly This is a subtle one. Typecasting takes precedence over, for example, division. So, we first typecasted an int to an uint8_t, loosing data in the process, and then do a seconds to minute conversion. This, obviously, does not give the result one expects. And in hindsight a trivial fix for a bug that like has been there forever. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Thu, 02 May 2019 13:08:17 +0200
parents 54d14bc2083c
children 50c26a4442af
line wrap: on
line diff
--- a/Discovery/Src/logbook.c	Wed May 01 14:45:47 2019 +0200
+++ b/Discovery/Src/logbook.c	Thu May 02 13:08:17 2019 +0200
@@ -520,7 +520,7 @@
 				{
 					sample[length] = 0;
 					length += 1;
-					sample[length] = (uint8_t)pDecoinfo->output_ndl_seconds / 60;
+					sample[length] = (uint8_t)(pDecoinfo->output_ndl_seconds / 60);
 
 					// Limit stored sample within 0 to 240 mins (Since it's 8bit UINT only)
 					if ((pDecoinfo->output_ndl_seconds / 60) > 240) sample[length] = 240;