comparison Discovery/Src/data_exchange_main.c @ 232:f0069f002c55 div-fixes-4-1

Bugfix: make date/time setting work over reboots Setting the time/date over the UART interface or by the menu, seems to work, but a reboot of the RTE brings back strange, seemingly random, time. The reason for this is rather simple. In the settings, a time is stored, based on some flawed logic, and that time was restored on reboot. There is no reason to store any time, when the moment of restoring it is unrelated in time. So, the fix is simple: do not set time (in the RTC) based on some time from the past. The whole idea of a RTC is that it does preserve the time for you, as long its powered. Any attempt to do things better using stored time data is futile (and nonsense). And while working on his, also kick out some useless code from the RTE. There is no reason to initialize the time on the RTC to some random time/date in the past. A zero data/time is as good and any random date. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Wed, 03 Apr 2019 21:11:56 +0200
parents 9fc06e1e0f66
children 2e58a4094770 189387bf23a8
comparison
equal deleted inserted replaced
231:f6961efb3794 232:f0069f002c55
403 403
404 if(DataEX_check_header_and_footer_ok() && (dataIn.power_on_reset == 1)) 404 if(DataEX_check_header_and_footer_ok() && (dataIn.power_on_reset == 1))
405 { 405 {
406 if(!wasUpdateNotPowerOn) 406 if(!wasUpdateNotPowerOn)
407 wasPowerOn = 1; 407 wasPowerOn = 1;
408
409 RTC_DateTypeDef Sdate;
410 RTC_TimeTypeDef Stime;
411
412 translateDate(settings->backup_localtime_rtc_dr, &Sdate);
413 translateTime(settings->backup_localtime_rtc_tr, &Stime);
414
415 dataOut.data.newTime = Stime;
416 dataOut.setTimeNow = 1;
417 dataOut.data.newDate = Sdate;
418 dataOut.setDateNow = 1;
419 408
420 settingsHelperButtonSens_keepPercentageValues(settingsGetPointerStandard()->ButtonResponsiveness[3], settings->ButtonResponsiveness); 409 settingsHelperButtonSens_keepPercentageValues(settingsGetPointerStandard()->ButtonResponsiveness[3], settings->ButtonResponsiveness);
421 setButtonResponsiveness(settings->ButtonResponsiveness); 410 setButtonResponsiveness(settings->ButtonResponsiveness);
422 411
423 // hw 160720 new lastKnownBatteryPercentage 412 // hw 160720 new lastKnownBatteryPercentage