annotate ostc4pack/create_full_update_bin.bat @ 319:d8e86af78474 fix-version

bugfix: correct packed main version number in dive header This fixes a rather mysterious bug. Users report that up to 1.3.5 beta, a correct version number is shown in libdivecomputer based applications (like in Subsurface, in the extra data tab). Careful examining the code in both libdivecomputer and the firmware shows a subtle error in the bit mask and shift operation to pack a full X.Y.Z.beta version number in 2 bytes (as is available in the dive header) in the firmware end (as the libdivecomputer code looks sane, assuming this is the right way to pack things). Likely, this bug crept in in the conversion from the closed source Keil period into the open source GCC setup of the code base. So its impossible to document the exact history of this problem here. Further notice that the main version number is only 1 of 3 version numbers, denoting the full version of the firmware (besides Font and RTE). Finally notice that this way of packing is limited to 2^5 bits (decimal 32), so we could easily build a 1.4.21, but not a 1.4.55. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Wed, 19 Jun 2019 14:31:50 +0200
parents f8b7642704dd
children 85ba20760ad4
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
60
96026ba1834f more language updates
heinrichsweikamp
parents:
diff changeset
1 call step0_copy_bins.bat
96026ba1834f more language updates
heinrichsweikamp
parents:
diff changeset
2 call step1_create_OSTC4_firmware_upload_bin.bat
96026ba1834f more language updates
heinrichsweikamp
parents:
diff changeset
3 call step1_create_OSTC_RTE_upload.bat
96026ba1834f more language updates
heinrichsweikamp
parents:
diff changeset
4 call step2_create_OSTC4update_bin.bat
96026ba1834f more language updates
heinrichsweikamp
parents:
diff changeset
5 pause