annotate OtherSources/stm32f4xx_hal_msp.c @ 319:d8e86af78474 fix-version

bugfix: correct packed main version number in dive header This fixes a rather mysterious bug. Users report that up to 1.3.5 beta, a correct version number is shown in libdivecomputer based applications (like in Subsurface, in the extra data tab). Careful examining the code in both libdivecomputer and the firmware shows a subtle error in the bit mask and shift operation to pack a full X.Y.Z.beta version number in 2 bytes (as is available in the dive header) in the firmware end (as the libdivecomputer code looks sane, assuming this is the right way to pack things). Likely, this bug crept in in the conversion from the closed source Keil period into the open source GCC setup of the code base. So its impossible to document the exact history of this problem here. Further notice that the main version number is only 1 of 3 version numbers, denoting the full version of the firmware (besides Font and RTE). Finally notice that this way of packing is limited to 2^5 bits (decimal 32), so we could easily build a 1.4.21, but not a 1.4.55. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Wed, 19 Jun 2019 14:31:50 +0200
parents 7801c5d8a562
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
5
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
1 /**
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
2 ******************************************************************************
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
3 * @file stm32f4xx_hal_msp.c
36
7801c5d8a562 Update author name for release
heinrichsweikamp
parents: 5
diff changeset
4 * @author heinrichs weikamp gmbh
5
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
5 * @date 05-Dec-2014
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
6 * @version V0.0.1
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
7 * @since 05-Dec-2014
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
8 * @brief loader for the hardware specific stm32f4xx_hal_msp.c
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
9 *
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
10 @verbatim
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
11 ==============================================================================
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
12 ##### How to use #####
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
13 ==============================================================================
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
14 @endverbatim
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
15 ******************************************************************************
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
16 * @attention
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
17 *
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
18 * <h2><center>&copy; COPYRIGHT(c) 2014 heinrichs weikamp</center></h2>
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
19 *
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
20 ******************************************************************************
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
21 */
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
22
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
23 /* Includes ------------------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
24
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
25 #include "ostc.h"
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
26
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
27 #ifdef OSTC_ON_DISCOVERY_HARDWARE
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
28 #include "stm32f4xx_hal_msp_discovery.c"
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
29 #else
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
30 #include "stm32f4xx_hal_msp_hw1.c"
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
31 #endif
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
32
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
33 /* Exported variables --------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
34
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
35 /* Private types -------------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
36
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
37 /* Private variables ---------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
38
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
39 /* Private variables with external access via get_xxx() function -------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
40
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
41 /* Private function prototypes -----------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
42
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
43 /* Exported functions --------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
44
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
45 /* Private functions ---------------------------------------------------------*/
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
46
e65d01b6a17e MOVE files for other applications
JeanDo
parents:
diff changeset
47 /************************ (C) COPYRIGHT heinrichs weikamp *****END OF FILE****/