annotate Current build/OSTC4update_190601.bin @ 319:d8e86af78474 fix-version

bugfix: correct packed main version number in dive header This fixes a rather mysterious bug. Users report that up to 1.3.5 beta, a correct version number is shown in libdivecomputer based applications (like in Subsurface, in the extra data tab). Careful examining the code in both libdivecomputer and the firmware shows a subtle error in the bit mask and shift operation to pack a full X.Y.Z.beta version number in 2 bytes (as is available in the dive header) in the firmware end (as the libdivecomputer code looks sane, assuming this is the right way to pack things). Likely, this bug crept in in the conversion from the closed source Keil period into the open source GCC setup of the code base. So its impossible to document the exact history of this problem here. Further notice that the main version number is only 1 of 3 version numbers, denoting the full version of the firmware (besides Font and RTE). Finally notice that this way of packing is limited to 2^5 bits (decimal 32), so we could easily build a 1.4.21, but not a 1.4.55. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl> --> -->
 
 
<type 'exceptions.AttributeError'>
Python 2.7.17: /usr/bin/python
Fri Sep 13 09:20:57 2024

A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.

 /var/www/vhosts/heinrichsweikamp.com/code/hgweb-public.cgi in <module>()
     15 
     16 from mercurial import demandimport; demandimport.enable()
     17 from mercurial.hgweb import hgweb, wsgicgi
     18 application = hgweb(config)
=>   19 wsgicgi.launch(application)
wsgicgi = <module 'mercurial.hgweb.wsgicgi' from '/usr/lib...on2.7/dist-packages/mercurial/hgweb/wsgicgi.pyc'>, wsgicgi.launch = <function launch>, application = <mercurial.hgweb.hgwebdir_mod.hgwebdir object>
 /usr/lib/python2.7/dist-packages/mercurial/hgweb/wsgicgi.py in launch(application=<mercurial.hgweb.hgwebdir_mod.hgwebdir object>)
     83     content = application(environ, start_response)
     84     try:
=>   85         for chunk in content:
     86             write(chunk)
     87         if not headers_sent:
chunk = '/public/ostc4/rev/d8e86af78474">changeset</a></l...ned-off-by: Jan Mulder &lt;jlmulder@xs4all.nl&gt;', content = <generator object run_wsgi>
 /usr/lib/python2.7/dist-packages/mercurial/hgweb/hgwebdir_mod.py in run_wsgi(self=<mercurial.hgweb.hgwebdir_mod.hgwebdir object>, req=<mercurial.hgweb.request.wsgirequest object>)
    227         with profiling.profile(self.ui, enabled=profile):
    228             try:
=>  229                 for r in self._runwsgi(req):
    230                     yield r
    231             finally:
r = '/public/ostc4/rev/d8e86af78474">changeset</a></l...ned-off-by: Jan Mulder &lt;jlmulder@xs4all.nl&gt;', self = <mercurial.hgweb.hgwebdir_mod.hgwebdir object>, self._runwsgi = <bound method hgwebdir._runwsgi of <mercurial.hgweb.hgwebdir_mod.hgwebdir object>>, req = <mercurial.hgweb.request.wsgirequest object>
 /usr/lib/python2.7/dist-packages/mercurial/hgweb/hgweb_mod.py in run_wsgi(self=<mercurial.hgweb.hgweb_mod.hgweb object>, req=<mercurial.hgweb.request.wsgirequest object>)
    316             profile = repo.ui.configbool('profiling', 'enabled')
    317             with profiling.profile(repo.ui, enabled=profile):
=>  318                 for r in self._runwsgi(req, repo):
    319                     yield r
    320 
r = '/public/ostc4/rev/d8e86af78474">changeset</a></l...ned-off-by: Jan Mulder &lt;jlmulder@xs4all.nl&gt;', self = <mercurial.hgweb.hgweb_mod.hgweb object>, self._runwsgi = <bound method hgweb._runwsgi of <mercurial.hgweb.hgweb_mod.hgweb object>>, req = <mercurial.hgweb.request.wsgirequest object>, repo = <filteredrepo:served <mercurial.localrepo.localrepository object>>
 /usr/lib/python2.7/dist-packages/mercurial/util.py in increasingchunks(source=<generator object _flatten>, min=4096, max=65536)
   1015     buf = []
   1016     blen = 0
=> 1017     for chunk in source:
   1018         buf.append(chunk)
   1019         blen += len(chunk)
chunk = '">\n ', source = <generator object _flatten>
 /usr/lib/python2.7/dist-packages/mercurial/templater.py in _flatten(thing=<generator object runtemplate>)
   1279                 yield pycompat.bytestr(i)
   1280             else:
=> 1281                 for j in _flatten(i):
   1282                     yield j
   1283 
j = '">\n<span>Ignore whitespace changes - </span>\n<sp..."ignorewseol-checkbox" type="checkbox" />\n</form>', global _flatten = <function _flatten>, i = <generator object runmap>
 /usr/lib/python2.7/dist-packages/mercurial/templater.py in _flatten(thing=<generator object runmap>)
   1270         yield pycompat.bytestr(thing)
   1271     else:
=> 1272         for i in thing:
   1273             i = templatekw.unwraphybrid(i)
   1274             if isinstance(i, bytes):
i undefined, thing = <generator object runmap>
 /usr/lib/python2.7/dist-packages/mercurial/templater.py in runmap(context=<mercurial.templater.engine object>, mapping={'annotate': <function annotate>, 'author': 'Jan Mulder <jlmulder@xs4all.nl>', 'bookmarks': [], 'branch': [{'name': 'fix-version'}], 'branches': [{'name': 'fix-version'}], 'child': <function <lambda>>, 'date': (1560947510.0, -7200), 'desc': 'bugfix: correct packed main version number in di....\n\nSigned-off-by: Jan Mulder <jlmulder@xs4all.nl>', 'diffopts': {'context': 3, 'git': False, 'ignoreblanklines': False, 'ignorews': False, 'ignorewsamount': False, 'ignorewseol': False, 'index': 0, 'nobinary': False, 'nodates': False, 'noprefix': False, ...}, 'extra': {'branch': 'fix-version'}, ...}, data=((<function runsymbol>, 'annotate'), (<function runtemplate>, [(<function runstring>, '\n<tr id="'), (<function runsymbol>, 'lineid'), (<function runstring>, '"'), (<function ifeq>, [(<function runsymbol>, 'node'), (<function runsymbol>, 'originalnode'), (<function runstring>, ' class="thisrev"')]), (<function runstring>, '>\n<td class="annotate parity'), (<function runsymbol>, 'blockparity'), (<function runstring>, '">\n'), (<function if_>, [(<function runsymbol>, 'blockhead'), (<function runtemplate>, [...])]), (<function runstring>, '\n<div class="annotate-info">\n<div>\n<a href="'), (<function runfilter>, ((<function runsymbol>, 'url'), <function urlescape>)), (<function runstring>, 'annotate/'), (<function runfilter>, ((<function runsymbol>, 'node'), <function short>)), (<function runstring>, '/'), (<function runfilter>, ((<function runsymbol>, 'file'), <function urlescape>)), (<function runmap>, ((<function runsymbol>, 'sessionvars'), (<function runtemplate>, [...]))), (<function runstring>, '#l'), (<function runsymbol>, 'targetline'), (<function runstring>, '">\n'), (<function runfilter>, ((<function runsymbol>, 'node'), <function short>)), (<function runstring>, '</a>\n'), ...])))
    460                 raise error.ParseError(_("%r is not iterable") % d)
    461 
=>  462     for i, v in enumerate(diter):
    463         lm = mapping.copy()
    464         lm['index'] = i
i undefined, v undefined, builtin enumerate = <type 'enumerate'>, diter = <generator object annotate>
 /usr/lib/python2.7/dist-packages/mercurial/hgweb/webcommands.py in annotate(**map={'annotate': <function annotate>, 'author': 'Jan Mulder <jlmulder@xs4all.nl>', 'bookmarks': [], 'branch': [{'name': 'fix-version'}], 'branches': [{'name': 'fix-version'}], 'child': <function <lambda>>, 'date': (1560947510.0, -7200), 'desc': 'bugfix: correct packed main version number in di....\n\nSigned-off-by: Jan Mulder <jlmulder@xs4all.nl>', 'diffopts': {'context': 3, 'git': False, 'ignoreblanklines': False, 'ignorews': False, 'ignorewsamount': False, 'ignorewseol': False, 'index': 0, 'nobinary': False, 'nodates': False, 'noprefix': False, ...}, 'extra': {'branch': 'fix-version'}, ...})
    907         blockparitygen = paritygen(1)
    908         for lineno, (aline, l) in enumerate(lines):
=>  909             f = aline.fctx
    910             rev = f.rev()
    911             if rev != previousrev:
f undefined, aline = (<filectx Current build/OSTC4update_190601.bin@49f5db6139d5>, 1), aline.fctx undefined

<type 'exceptions.AttributeError'>: 'tuple' object has no attribute 'fctx'
      args = ("'tuple' object has no attribute 'fctx'",)
      message = "'tuple' object has no attribute 'fctx'"