Mercurial > public > ostc4
annotate Common/Inc/global_constants.h @ 224:ceecabfddb57 div-fixes-3
Bugfix, deco: fix 2 (small) problems with calculated ceiling
This fixes 1 trivial, and 1 not really trivial bug in the calculation
of the ceiling. When simulating a bounce dive to 80m, things become
clear (tried this on a CCR dive, fixed setpoint 1.2bar, about 15 minutes
of bottom time). Closely watch the behavior of the ceiling data. At some
point during the ascent, the ceiling begins to decrease in 10cm steps.
Then suddenly (while still ascending), the ceiling increases again with 1m,
does not change for some time, and then suddenly steps 1.1m less deep.
While not very relevant to real deco diving, it is simply wrong.
The reason for this is subtle. The algorithm used to find the ceiling
is a sort of linear search, stepping down a meter, overshoot the depth, and
search back in 10cm steps. It seems some numerical instability. Fixing
this, was a bit more computational intensive search by stepping up down in
equal steps of 10cm. But, I'm pretty sure that things can be speeded up here, as a
ceiling does not change fast, so it should be not that difficult to limit
the search space, or use a binary search algorithm instead.
The trivial second problem fixed, is that the ceiling ends at the surface
and not at 1m depth. This small issue became visible after changing the step
down size above.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author | Jan Mulder <jlmulder@xs4all.nl> |
---|---|
date | Sun, 31 Mar 2019 19:35:51 +0200 |
parents | 9fc06e1e0f66 |
children | a6c0375bc950 |
rev | line source |
---|---|
101 | 1 /////////////////////////////////////////////////////////////////////////////// |
2 /// -*- coding: UTF-8 -*- | |
3 /// | |
4 /// \file Common/Inc/global_constants.h | |
5 /// \brief | |
6 /// \author Dmitry Romanov<kitt@bk.ru> | |
7 /// \date 11.2018 | |
8 /// | |
9 /// $Id$ | |
10 /////////////////////////////////////////////////////////////////////////////// | |
11 /// \par Copyright (c) 2014-2018 Heinrichs Weikamp gmbh | |
12 /// | |
13 /// This program is free software: you can redistribute it and/or modify | |
14 /// it under the terms of the GNU General Public License as published by | |
15 /// the Free Software Foundation, either version 3 of the License, or | |
16 /// (at your option) any later version. | |
17 /// | |
18 /// This program is distributed in the hope that it will be useful, | |
19 /// but WITHOUT ANY WARRANTY; without even the implied warranty of | |
20 /// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
21 /// GNU General Public License for more details. | |
22 /// | |
23 /// You should have received a copy of the GNU General Public License | |
24 /// along with this program. If not, see <http://www.gnu.org/licenses/>. | |
25 ////////////////////////////////////////////////////////////////////////////// | |
26 | |
27 #ifndef GLOBAL_CONSTANTS_H | |
28 #define GLOBAL_CONSTANTS_H | |
29 //Rename it ahead. | |
30 //Buttons section | |
172
c659fda83e44
Minor: Button defaults, release date adjusted, use SPI_SHOW_SYNC_STATS
heinrichsweikamp
parents:
153
diff
changeset
|
31 #define DEFAULT_BUTTONRESPONSIVENESS_GUI 85 |
101 | 32 #define MIN_BUTTONRESPONSIVENESS_GUI 30 //50 (-10correction) |
33 #define MAX_BUTTONRESPONSIVENESS_GUI 110//100 (+10correction) | |
34 #define MIN_BUTTONRESPONSIVENESS MIN_BUTTONRESPONSIVENESS_GUI-20 //MIN_BUTTONRESPONSIVENESS_GUI-20 correction | |
35 #define MAX_BUTTONRESPONSIVENESS MAX_BUTTONRESPONSIVENESS_GUI+20//MIN_BUTTONRESPONSIVENESS_GUI+20correction | |
36 #define BUTTON_DEBOUNCE_DELAY 50 //Delay for debounce filter for piezo buttons | |
37 | |
38 | |
153
791cdfad0c8e
Added definitions for SPI sequence counter
Ideenmodellierer
parents:
104
diff
changeset
|
39 // Spi sync data debug |
172
c659fda83e44
Minor: Button defaults, release date adjusted, use SPI_SHOW_SYNC_STATS
heinrichsweikamp
parents:
153
diff
changeset
|
40 #define SPI_SHOW_SYNC_STATS 0 |
104 | 41 #define SPI_MIN_ERROR_SHOW 10 |
103
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
42 |
208 | 43 /* Define INDEX for information exchanged within the header */ |
44 #define SPI_HEADER_INDEX_RX_STATE (1) | |
45 #define SPI_HEADER_INDEX_FRAME_CNT (2) | |
153
791cdfad0c8e
Added definitions for SPI sequence counter
Ideenmodellierer
parents:
104
diff
changeset
|
46 |
208 | 47 #define SPI_RX_STATE_OK (0) |
48 #define SPI_RX_STATE_SHIFTED (1) | |
49 #define SPI_RX_STATE_OFFLINE (2) | |
50 #define SPI_RX_STATE_INVALID (3) | |
103
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
51 |
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
52 //Text data |
f5d2f02dc73f
Generalize TEXT of pressure unit
Dmitry Romanov <kitt@bk.ru>
parents:
101
diff
changeset
|
53 #define TEXT_PRESSURE_UNIT "hPa" |
101 | 54 #endif |