Mercurial > public > ostc4
annotate ostc4pack/OSTC4_RTE.bin @ 238:a9d798e8c11f div-fixes-5
cleanup, bugfix: do not mask I2C_SystemStatus with local variable
This commit is partly cleanup, and partly possible bugfix. Masking
the global I2C_SystemStatus with a local variable is (very) bad practice,
but more importantly, dangerous, as other code uses this I2C_SystemStatus
to base decisions on. So, this is definitely non-trivial, as it can
possibly change the flow of control. This said, its tested and seems to
have no negative effects (but also no positive, as I sort of hoped for),
so that is why I mark it cleanup as well. Constructs like this shall
be heavily documented in the code, when there is a reason to do things
like this.
Further, remove a 2nd rather useless construct. There is no reason
to & 0x03 the output of I2C_SystemStatus. This is the only location
in the entire code base where this is done, so, its not only useless
but also inconsistent and confusing the true intentions here.
Finally, littered to code with todo's that I will take care of in
next commits.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
--> -->
<type 'exceptions.AttributeError'> | Python 2.7.17: /usr/bin/python Sun Oct 6 02:33:38 2024 |
A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.
/var/www/vhosts/heinrichsweikamp.com/code/hgweb-public.cgi in <module>() |
15 |
16 from mercurial import demandimport; demandimport.enable() |
17 from mercurial.hgweb import hgweb, wsgicgi |
18 application = hgweb(config) |
=> 19 wsgicgi.launch(application) |
wsgicgi = <module 'mercurial.hgweb.wsgicgi' from '/usr/lib...on2.7/dist-packages/mercurial/hgweb/wsgicgi.pyc'>, wsgicgi.launch = <function launch>, application = <mercurial.hgweb.hgwebdir_mod.hgwebdir object> |
/usr/lib/python2.7/dist-packages/mercurial/hgweb/wsgicgi.py in launch(application=<mercurial.hgweb.hgwebdir_mod.hgwebdir object>) |
83 content = application(environ, start_response) |
84 try: |
=> 85 for chunk in content: |
86 write(chunk) |
87 if not headers_sent: |
chunk = 'rev/a9d798e8c11f">changeset</a></li>\n<li><a href...ned-off-by: Jan Mulder <jlmulder@xs4all.nl>', content = <generator object run_wsgi> |
/usr/lib/python2.7/dist-packages/mercurial/hgweb/hgwebdir_mod.py in run_wsgi(self=<mercurial.hgweb.hgwebdir_mod.hgwebdir object>, req=<mercurial.hgweb.request.wsgirequest object>) |
227 with profiling.profile(self.ui, enabled=profile): |
228 try: |
=> 229 for r in self._runwsgi(req): |
230 yield r |
231 finally: |
r = 'rev/a9d798e8c11f">changeset</a></li>\n<li><a href...ned-off-by: Jan Mulder <jlmulder@xs4all.nl>', self = <mercurial.hgweb.hgwebdir_mod.hgwebdir object>, self._runwsgi = <bound method hgwebdir._runwsgi of <mercurial.hgweb.hgwebdir_mod.hgwebdir object>>, req = <mercurial.hgweb.request.wsgirequest object> |
/usr/lib/python2.7/dist-packages/mercurial/hgweb/hgweb_mod.py in run_wsgi(self=<mercurial.hgweb.hgweb_mod.hgweb object>, req=<mercurial.hgweb.request.wsgirequest object>) |
316 profile = repo.ui.configbool('profiling', 'enabled') |
317 with profiling.profile(repo.ui, enabled=profile): |
=> 318 for r in self._runwsgi(req, repo): |
319 yield r |
320 |
r = 'rev/a9d798e8c11f">changeset</a></li>\n<li><a href...ned-off-by: Jan Mulder <jlmulder@xs4all.nl>', self = <mercurial.hgweb.hgweb_mod.hgweb object>, self._runwsgi = <bound method hgweb._runwsgi of <mercurial.hgweb.hgweb_mod.hgweb object>>, req = <mercurial.hgweb.request.wsgirequest object>, repo = <filteredrepo:served <mercurial.localrepo.localrepository object>> |
/usr/lib/python2.7/dist-packages/mercurial/util.py in increasingchunks(source=<generator object _flatten>, min=4096, max=65536) |
1015 buf = [] |
1016 blen = 0 |
=> 1017 for chunk in source: |
1018 buf.append(chunk) |
1019 blen += len(chunk) |
chunk = '">\n ', source = <generator object _flatten> |
/usr/lib/python2.7/dist-packages/mercurial/templater.py in _flatten(thing=<generator object runtemplate>) |
1279 yield pycompat.bytestr(i) |
1280 else: |
=> 1281 for j in _flatten(i): |
1282 yield j |
1283 |
j = '">\n<span>Ignore whitespace changes - </span>\n<sp..."ignorewseol-checkbox" type="checkbox" />\n</form>', global _flatten = <function _flatten>, i = <generator object runmap> |
/usr/lib/python2.7/dist-packages/mercurial/templater.py in _flatten(thing=<generator object runmap>) |
1270 yield pycompat.bytestr(thing) |
1271 else: |
=> 1272 for i in thing: |
1273 i = templatekw.unwraphybrid(i) |
1274 if isinstance(i, bytes): |
i undefined, thing = <generator object runmap> |
/usr/lib/python2.7/dist-packages/mercurial/templater.py in runmap(context=<mercurial.templater.engine object>, mapping={'annotate': <function annotate>, 'author': 'Jan Mulder <jlmulder@xs4all.nl>', 'bookmarks': [], 'branch': [{'name': 'div-fixes-5'}], 'branches': [], 'child': <function <lambda>>, 'date': (1554711377.0, -7200), 'desc': 'cleanup, bugfix: do not mask I2C_SystemStatus wi....\n\nSigned-off-by: Jan Mulder <jlmulder@xs4all.nl>', 'diffopts': {'context': 3, 'git': False, 'ignoreblanklines': False, 'ignorews': False, 'ignorewsamount': False, 'ignorewseol': False, 'index': 0, 'nobinary': False, 'nodates': False, 'noprefix': False, ...}, 'extra': {'branch': 'div-fixes-5', 'histedit_source': '16eae803cd5a3fb2185d1128609dd4651b67e892'}, ...}, data=((<function runsymbol>, 'annotate'), (<function runtemplate>, [(<function runstring>, '\n<tr id="'), (<function runsymbol>, 'lineid'), (<function runstring>, '"'), (<function ifeq>, [(<function runsymbol>, 'node'), (<function runsymbol>, 'originalnode'), (<function runstring>, ' class="thisrev"')]), (<function runstring>, '>\n<td class="annotate parity'), (<function runsymbol>, 'blockparity'), (<function runstring>, '">\n'), (<function if_>, [(<function runsymbol>, 'blockhead'), (<function runtemplate>, [...])]), (<function runstring>, '\n<div class="annotate-info">\n<div>\n<a href="'), (<function runfilter>, ((<function runsymbol>, 'url'), <function urlescape>)), (<function runstring>, 'annotate/'), (<function runfilter>, ((<function runsymbol>, 'node'), <function short>)), (<function runstring>, '/'), (<function runfilter>, ((<function runsymbol>, 'file'), <function urlescape>)), (<function runmap>, ((<function runsymbol>, 'sessionvars'), (<function runtemplate>, [...]))), (<function runstring>, '#l'), (<function runsymbol>, 'targetline'), (<function runstring>, '">\n'), (<function runfilter>, ((<function runsymbol>, 'node'), <function short>)), (<function runstring>, '</a>\n'), ...]))) |
460 raise error.ParseError(_("%r is not iterable") % d) |
461 |
=> 462 for i, v in enumerate(diter): |
463 lm = mapping.copy() |
464 lm['index'] = i |
i undefined, v undefined, builtin enumerate = <type 'enumerate'>, diter = <generator object annotate> |
/usr/lib/python2.7/dist-packages/mercurial/hgweb/webcommands.py in annotate(**map={'annotate': <function annotate>, 'author': 'Jan Mulder <jlmulder@xs4all.nl>', 'bookmarks': [], 'branch': [{'name': 'div-fixes-5'}], 'branches': [], 'child': <function <lambda>>, 'date': (1554711377.0, -7200), 'desc': 'cleanup, bugfix: do not mask I2C_SystemStatus wi....\n\nSigned-off-by: Jan Mulder <jlmulder@xs4all.nl>', 'diffopts': {'context': 3, 'git': False, 'ignoreblanklines': False, 'ignorews': False, 'ignorewsamount': False, 'ignorewseol': False, 'index': 0, 'nobinary': False, 'nodates': False, 'noprefix': False, ...}, 'extra': {'branch': 'div-fixes-5', 'histedit_source': '16eae803cd5a3fb2185d1128609dd4651b67e892'}, ...}) |
907 blockparitygen = paritygen(1) |
908 for lineno, (aline, l) in enumerate(lines): |
=> 909 f = aline.fctx |
910 rev = f.rev() |
911 if rev != previousrev: |
f undefined, aline = (<filectx ostc4pack/OSTC4_RTE.bin@c659fda83e44>, 1), aline.fctx undefined |
<type 'exceptions.AttributeError'>: 'tuple' object has no attribute 'fctx'
args =
("'tuple' object has no attribute 'fctx'",)
message =
"'tuple' object has no attribute 'fctx'"