annotate RefPrj/FontPack/.project @ 238:a9d798e8c11f div-fixes-5

cleanup, bugfix: do not mask I2C_SystemStatus with local variable This commit is partly cleanup, and partly possible bugfix. Masking the global I2C_SystemStatus with a local variable is (very) bad practice, but more importantly, dangerous, as other code uses this I2C_SystemStatus to base decisions on. So, this is definitely non-trivial, as it can possibly change the flow of control. This said, its tested and seems to have no negative effects (but also no positive, as I sort of hoped for), so that is why I mark it cleanup as well. Constructs like this shall be heavily documented in the code, when there is a reason to do things like this. Further, remove a 2nd rather useless construct. There is no reason to & 0x03 the output of I2C_SystemStatus. This is the only location in the entire code base where this is done, so, its not only useless but also inconsistent and confusing the true intentions here. Finally, littered to code with todo's that I will take care of in next commits. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Mon, 08 Apr 2019 10:16:17 +0200
parents b33c7f2ae0d9
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
79
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
1 <?xml version="1.0" encoding="UTF-8"?>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
2 <projectDescription>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
3 <name>OSTC4_FontPack</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
4 <comment></comment>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
5 <projects>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
6 </projects>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
7 <buildSpec>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
8 <buildCommand>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
9 <name>org.eclipse.cdt.managedbuilder.core.genmakebuilder</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
10 <triggers>clean,full,incremental,</triggers>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
11 <arguments>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
12 </arguments>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
13 </buildCommand>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
14 <buildCommand>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
15 <name>org.eclipse.cdt.managedbuilder.core.ScannerConfigBuilder</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
16 <triggers>full,incremental,</triggers>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
17 <arguments>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
18 </arguments>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
19 </buildCommand>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
20 </buildSpec>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
21 <natures>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
22 <nature>org.eclipse.cdt.core.cnature</nature>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
23 <nature>org.eclipse.cdt.managedbuilder.core.managedBuildNature</nature>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
24 <nature>org.eclipse.cdt.managedbuilder.core.ScannerConfigNature</nature>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
25 <nature>fr.ac6.mcu.ide.core.MCUProjectNature</nature>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
26 <nature>fr.ac6.mcu.ide.core.MCUSingleCoreProjectNature</nature>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
27 </natures>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
28 <linkedResources>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
29 <link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
30 <name>Common</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
31 <type>2</type>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
32 <locationURI>OSTC4/Common</locationURI>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
33 </link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
34 <link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
35 <name>Discovery</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
36 <type>2</type>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
37 <locationURI>OSTC4/Discovery</locationURI>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
38 </link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
39 <link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
40 <name>src/base_upperRegion.c</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
41 <type>1</type>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
42 <locationURI>OSTC4/FontPack/base_upperRegion.c</locationURI>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
43 </link>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
44 </linkedResources>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
45 <variableList>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
46 <variable>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
47 <name>OSTC4</name>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
48 <value>$%7BWORKSPACE_LOC%7D/ostc4</value>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
49 </variable>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
50 </variableList>
b33c7f2ae0d9 Added Fontpack reference project
Ideenmodellierer
parents:
diff changeset
51 </projectDescription>