annotate Current build/readme.txt @ 238:a9d798e8c11f div-fixes-5

cleanup, bugfix: do not mask I2C_SystemStatus with local variable This commit is partly cleanup, and partly possible bugfix. Masking the global I2C_SystemStatus with a local variable is (very) bad practice, but more importantly, dangerous, as other code uses this I2C_SystemStatus to base decisions on. So, this is definitely non-trivial, as it can possibly change the flow of control. This said, its tested and seems to have no negative effects (but also no positive, as I sort of hoped for), so that is why I mark it cleanup as well. Constructs like this shall be heavily documented in the code, when there is a reason to do things like this. Further, remove a 2nd rather useless construct. There is no reason to & 0x03 the output of I2C_SystemStatus. This is the only location in the entire code base where this is done, so, its not only useless but also inconsistent and confusing the true intentions here. Finally, littered to code with todo's that I will take care of in next commits. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Mon, 08 Apr 2019 10:16:17 +0200
parents d5891007fc4c
children dff26bf4b542
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
227
d5891007fc4c add update files for testing purposes
heinrichsweikamp
parents:
diff changeset
1 Heinrichs Weikamp OSTC4 update files.
d5891007fc4c add update files for testing purposes
heinrichsweikamp
parents:
diff changeset
2
d5891007fc4c add update files for testing purposes
heinrichsweikamp
parents:
diff changeset
3 The builds are for testing purposes only. Be careful, they might not work and are definitely not recommended for real dives.