annotate Small_CPU/Inc/pressure.h @ 306:2f43419102c8 cleanup-4

bugfix, cleanup: do not clip depth to 0 A real dive with the previous commits shows that testing from the simulator cannot be fully trusted in relation to logic that is close to the depth sensor (that is obviously bypassed using the simulator). So 1) there is 3 second interval between the stopwatch and the divetime, and 2) the depth flips from 1m depth to surface 0m depth, and that is visible in the profile data. Point 2) is definitely caused by the removed code in this commit. It likely is not right to clip the depth value at all. It is fine to base decisions like is done in is_ambient_pressure_close_to_surface on it, but clipping the depth value itself is seems wrong. This has become more prominent with commit eba8d1eb5bef where the clipping depth changed from 40cm of depth to 1m of depth. When comparing profiles from an OSTC Plus, it shows that no depth clipping is present there, so that is one more argument to remove it here. Point 1) The 3 sec interval is likely not a coincidence. It is the time to travel for 1m depth with a default descend speed of 20m/min. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
author Jan Mulder <jlmulder@xs4all.nl>
date Wed, 22 May 2019 14:39:04 +0200
parents 8e9c502c0b06
children 37f45300bc2e
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
38
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
1 /* Define to prevent recursive inclusion -------------------------------------*/
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
2 #ifndef PRESSURE_H
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
3 #define PRESSURE_H
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
4
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
5 #include <stdint.h>
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
6
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
7 uint8_t init_pressure(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
8 uint8_t pressure_update(void);
276
8e9c502c0b06 Rework pressure/ temperature data aquisition
ideenmodellierer
parents: 38
diff changeset
9 void pressure_update_alternating(void);
38
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
10
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
11 uint8_t is_init_pressure_done(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
12
276
8e9c502c0b06 Rework pressure/ temperature data aquisition
ideenmodellierer
parents: 38
diff changeset
13 HAL_StatusTypeDef pressure_sensor_get_pressure_raw(void);
8e9c502c0b06 Rework pressure/ temperature data aquisition
ideenmodellierer
parents: 38
diff changeset
14 HAL_StatusTypeDef pressure_sensor_get_temperature_raw(void);
38
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
15 void pressure_calculation(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
16
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
17 float get_temperature(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
18 float get_pressure_mbar(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
19 float get_surface_mbar(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
20
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
21 void init_surface_ring(void);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
22 void update_surface_pressure(uint8_t call_rhythm_seconds);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
23
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
24 uint32_t demo_modify_temperature_and_pressure(int32_t divetime_in_seconds, uint8_t subseconds, float ceiling_mbar);
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
25
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
26 #endif /* PRESSURE_H */
5f11787b4f42 include in ostc4 repository
heinrichsweikamp
parents:
diff changeset
27